feat: Install pinned version rather than latest tag #27
Conversation
mkilchhofer
force-pushed
the
feature/fixed_version_and_values_documentation
branch
3 times, most recently
from
12dba1e
to
a718255
Compare
| namespaceSelector: {} | ||
| ## Default: scrape .Release.Namespace only | ||
| ## To scrape all, use the following: | ||
| ## namespaceSelector: | ||
| ## any: true |
There was a problem hiding this comment.
Removed namespaceSelector from values, as template does not honor this.
| scrapeInterval: 30s | ||
| # honorLabels: true | ||
| targetLabels: [] |
There was a problem hiding this comment.
Removed targetLabels from values, as template does not honor this.
|
nice work. Btw I opened this ticket a few days ago: #23 |
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
force-pushed
the
feature/fixed_version_and_values_documentation
branch
from
a718255
to
59ef8c4
Compare
Yeah this can be discussed in further PRs. I have several additional changes I'd like to propose but I will do that in a different PR. ;) In my day-to-day job we have a Code of conduct where we should only file the changes that are required to a specific feature. :-) |
Signed-off-by: Tony Scott <toscott@users.noreply.github.com>
There was a mismatch between badges (AppVersion: 1.9.8) and version installed (latest tag).
While I fixed this, I documented every helm parameter via the required comments above each value. Let me know if I should split it into multiple PRs.
Resolves #23