fix clear copyset creating flag when create copyset success #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
cw123
force-pushed
the
fix_copyset_creating_flag
branch
from
0f24cd6
to
bfac19d
Compare
|
recheck |
1 similar comment
|
recheck |
wu-hanqing
reviewed
May 12, 2022
| @@ -866,6 +866,7 @@ TopoStatusCode TopologyManager::CreateCopyset( | |||
| return ret; | |||
| } | |||
|
|
|||
| ClearCopysetCreating(copyset.poolId, copyset.copysetId); | |||
There was a problem hiding this comment.
it's better to move this line of code before 856 and remove line 865, so you don't have to repeat it.
and should you add some unit test?
There was a problem hiding this comment.
虽然都是去掉creating的标记，但是清理的时机是不一样的。如果都挪到856行，和原意还是有区别的。
Although the marking of creating is removed, the timing of cleaning is different. If it is moved to line 856, it is still different from the original intention.
cw123
force-pushed
the
fix_copyset_creating_flag
branch
from
bfac19d
to
a8f909c
Compare
wu-hanqing
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #1382
Problem Summary: Copyset is not automatically migrated after stopping metaserver
What is changed and how it works?
What's Changed: fix clear copyset creating flag when create copyset success
When copyset created success, it should clear the copyset creating flag. But the code miss this in code.