ansible: fix grep error and bool type var #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHai
force-pushed
the
ansible_fix_when_warning
branch
from
1c0e9e0
to
25a0b5f
Compare
Wine93
reviewed
Apr 27, 2021
| when: not retain_pool | bool and not walfilepool_use_chunk_file_pool | bool |
There was a problem hiding this comment.
I think it's better to add some brackets to let the statement more clear.
There was a problem hiding this comment.
I think it's better to add some brackets to let the statement more clear.
done
cw123
reviewed
Apr 27, 2021
| @@ -127,19 +127,19 @@ | |||
| - { role: generate_config, template_name: chunkserver.conf, conf_path: "{{ chunkserver_conf_path }}", | |||
| tags: ["generate_config", "generage_chunkserver_conf"] } | |||
| - { role: generate_config, template_name: client.conf, conf_path: "{{ chunkserver_client_config_path }}", | |||
| tags: ["generate_config", "generage_chunkserver_conf"] } | |||
| tags: ["generate_config", "generage_chunkserver_client_conf"] } | |||
There was a problem hiding this comment.
Curve-ansible here change some tags. Do you check if any deploy document or wiki need change？
There was a problem hiding this comment.
Curve-ansible here change some tags. Do you check if any deploy document or wiki need change？
yes, the doc use like "ansible-playbook deploy_curve.yml -i server.ini --tags generage_chunkserver_conf,generage_chunkserver_client_conf". This issue found in the process of expansion.
SeanHai
force-pushed
the
ansible_fix_when_warning
branch
from
25a0b5f
to
55dbb51
Compare
cw123
approved these changes
Apr 27, 2021
Wine93
approved these changes
Apr 27, 2021
ilixiaocui
approved these changes
Apr 27, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
Added Thanos Spring 2021 LFX Projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List