ansible: fix some issues #380
Conversation
SeanHai
force-pushed
the
curve_ansible
branch
2 times, most recently
from
550d0f4
to
bca490f
Compare
|
|
||
| - name: generate curve-monitor.sh | ||
| template: src=curve-monitor.sh.j2 dest={{ deploy_dir }}/curve-monitor.sh mode=0755 | ||
| - name: install package without deb |
There was a problem hiding this comment.
Why is it not installed via tar？
There was a problem hiding this comment.
Why is it not installed via tar？
fixed all
| @@ -0,0 +1,30 @@ | |||
| --- | |||
| # | |||
| # Copyright (c) 2020 NetEase Inc. | |||
There was a problem hiding this comment.
The date of copyright shoud be 2021.
There was a problem hiding this comment.
The date of copyright shoud be
2021.
fixed
| @@ -25,6 +25,7 @@ | |||
| hosts: client | |||
| gather_facts: no | |||
| any_errors_fatal: true | |||
| become: "{{ sudo_or_not | bool }}" | |||
There was a problem hiding this comment.
Maybe we should add sudo_or_not and other related fields inclient.ini file.
There was a problem hiding this comment.
Maybe we should add
sudo_or_notand other related fields inclient.inifile.
this pr has included the field 'https://github.com/opencurve/curve/pull/370/files'
| remote_dir_name: "{{ monitor_work_dir }}" | ||
| local_file_path: "{{ local_monitor_package_path }}/" | ||
| file_mode: 0777 | ||
| include_tasks: copy_file_to_remote.yml |
There was a problem hiding this comment.
The task genrate curve-monitor.sh lost.
There was a problem hiding this comment.
The task
genrate curve-monitor.shlost.
because the 'curve-monitor.sh' has included in debain and tar pacages, so don't need creat again.
| template: src=snapshot-daemon.sh.j2 dest={{ deploy_dir }}/snapshot-daemon.sh mode=0755 |
There was a problem hiding this comment.
typo: redunrant ending whitespace.
There was a problem hiding this comment.
typo: redunrant ending whitespace.
A black line is needed at end of file.
| local_file_path: "{{ local_chunkserver_package_path }}/bin/" | ||
| file_mode: 0755 | ||
| include_tasks: copy_file_to_remote.yml | ||
| - name: install package via tar |
There was a problem hiding this comment.
why not install the same as
incluede_tasks: "install_tar_package.yml"?
There was a problem hiding this comment.
why not install the same as
incluede_tasks: "install_tar_package.yml"?
because install via tar package do different things based on installed package name. So can not give a unified task.
Add project for TUF
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List