Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MacOS with M1 build #507

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Added MacOS with M1 build #507

merged 1 commit into from
Jul 7, 2021

Conversation

asenyaev
Copy link
Contributor

@asenyaev asenyaev commented Jun 30, 2021

  1. Created MacOS with M1 build using arm64.
  2. Added exceptions for the workflows, which will not trigger other builds if there are no changes in these files.
  3. Added exceptions for arm64 platform in pyproject.toml


- name: build script
run: |
git submodule update --init multibuild
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need multibuild here, as we do all the build steps manually. To be honest, I've started thinking we do not need multibuild for all other builders too, as our required steps are simple and we already do them for OSX and windows. But this is a discussion for the other PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will change the flow of the build without multibuild and prepare another PR.

@sergregory sergregory merged commit 2344814 into opencv:master Jul 7, 2021
@luisdemarchi
Copy link

@sergregory It's been 14 hours since this merge was done, but it's been 8 hours since I needed to do the manual build. Where did I go wrong?

@sergregory
Copy link
Collaborator

@luisdemarchi probably, you did everything right - having a merge here doesn't mean we have a new release deployed to PyPI. We try to align the release cycle with the opencv release cycle, so now we're working on 4.5.3 and expect it to be ready this week.

@DanLipsitt
Copy link

@sergregory Any chance of deploying this first, since right now there's no release for M1 at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants