Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add universal intrinsics for RGB2HSV_f #11418

Merged
merged 1 commit into from
May 10, 2018
Merged

add universal intrinsics for RGB2HSV_f #11418

merged 1 commit into from
May 10, 2018

Conversation

K-Shinotsuka
Copy link
Contributor

@K-Shinotsuka K-Shinotsuka commented Apr 28, 2018 •
edited
Loading

I add universal intrinsics for RGB2HSV_f.

force_builders=Custom,armv7,armv8
docker_image:Custom=powerpc64le

Intel measurement result
srccnnAverage Clocks (original code)Average Clocks (new code)Faster Rate (compared with original code)
3241744.2596.2292.6%
3483424.01167.0293.4%
3725099.41699.4300.1%
4241743.2647.6269.2%
4483474.41241.8279.8%
4725091.01870.8272.1%

Measurement Conditions
OS : Ubuntu 17.10
Compiler : g++ (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
CPU : Intel(R) Core(TM)2 Duo CPU E8500 @ 3.16GHz
Compiler Option : -msse -O3
Measurement Function: rdtsc()


ARM measurement result

srccnnAverage Clocks (original code)Average Clocks (new code)Faster Rate (compared with original code)
3242630.61723.0152.7%
3484056.62209.8183.6%
3725608.82825.2198.5%
4242597.61530.6169.7%
4484081.62103.4194.0%
4725566.42657.2209.5%

Measurement Conditions
OS : Android 6.0.1
Compiler : android-ndk-r10e ndk-build
CPU : Tegra K1 Dual Denver 2.3GHz
Additional Compiler Option : -O3 -mcpu=cortex-a8 -mfpu=neon -mfloat-abi=softfp -fPIC -march=armv7-a -ffunction-sections -funwind-tables -fstack-protector -fno-short-enums -fno-exceptions -fno-rtti
Measurement Function: clock_gettime()

@K-Shinotsuka K-Shinotsuka changed the base branch from master to 3.4 April 28, 2018 12:13
@K-Shinotsuka K-Shinotsuka force-pushed the issue42 branch 2 times, most recently from 8fe7b5c to 33fa7a9 Compare April 28, 2018 14:42
@K-Shinotsuka K-Shinotsuka changed the title test use v_select at HSV2RGB_f Apr 28, 2018
@K-Shinotsuka K-Shinotsuka force-pushed the issue42 branch 2 times, most recently from d54d417 to 232f5df Compare April 30, 2018 06:38
@K-Shinotsuka K-Shinotsuka changed the title use v_select at HSV2RGB_f add universal intrinsics for RGB2HLS_f Apr 30, 2018
@K-Shinotsuka K-Shinotsuka changed the title add universal intrinsics for RGB2HLS_f add universal intrinsics for RGB2HSV_f Apr 30, 2018
@K-Shinotsuka K-Shinotsuka force-pushed the issue42 branch 3 times, most recently from 9d42c50 to 693f055 Compare May 3, 2018 10:47
@vpisarev vpisarev self-assigned this May 10, 2018
@vpisarev
Copy link
Contributor

looks great! 👍

@opencv-pushbot opencv-pushbot merged commit ecb4ea8 into opencv:3.4 May 10, 2018
opencv-pushbot pushed a commit that referenced this pull request May 10, 2018
@vpisarev
Merge pull request #11418 from K-Shinotsuka:issue42
9e3b6a2
@alalek alalek mentioned this pull request May 10, 2018
Merged
@K-Shinotsuka
Copy link
Contributor Author

Thank you for reviewing and merging.

@K-Shinotsuka K-Shinotsuka deleted the issue42 branch May 12, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vpisarev vpisarev

Labels
category: imgproc optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K-Shinotsuka @vpisarev @opencv-pushbot @alalek