-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api specs fixes #1898
Api specs fixes #1898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we automate specs validation in a test?
I think we should. In this PR or another ? |
@noirbizarre in this PR if you have time I think it's OK |
Added validation testing. ( |
udata/api/commands.py
Outdated
schema = json.loads(json.dumps(api.__schema__)) | ||
try: | ||
schemas.validate(schema) | ||
success('API specificationsare valid') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/specificationsare/specifications are/
This PR fixes a lot of
swagger.json
API specs bugs allowing it to validate and so being able to use swagger tools that weren't working (like the new version of Swagger UI).Some fixes are on the
flask-restplus
side so it has been updated with it