-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/typos #2023
Bugfix/typos #2023
Conversation
Also fixes a few typos.
- optional => optionnal
- optionnal => optional - optionnaly => optionally No function or variable has been changed in this commit.
The function's name is not used anywhere else in the codebase.
- UData => uData - Optionnal => Optional - Ex => E.g. And a few more tiny fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few hurdles before merging:
- please close Fixing a few typos in the documentation and UI/translation strings #2022
- please add the link to this PR in the CHANGELOG
- please use
fix #2021
in the PR description to auto-close the associated issue when merged
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed something: renaming versioning.md
has some consequences:
mkdocs.yml
should be updated- there's a link in the CHANGELOG the
/versionning
that should be renamed
I've done the requested updates, I hope we're all set now. Thanks for the careful and detailed guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You can merge now if you can, if not tell me and I will.
Done, thanks again. |
Follow the directions proposed in #2022
fix #2021