Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin werkzeug==0.14.1 #2081

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Pin werkzeug==0.14.1 #2081

merged 1 commit into from
Mar 25, 2019

Conversation

noirbizarre
Copy link
Contributor

This PR pin Werkzeug to version 0.14.1 until incompatibilities with the new 0.15+ are fixed (See Werkzeug changelog).

First investigations and tests show that:

  • static URL resolution is broken
  • test are taking twice the time (localy, they are killed on CircleCI).
  • some used modules have moved or have been refactored

Update to 0.15+ might happen in udata 2+ in a PR

@noirbizarre noirbizarre added this to the 1.6.6 milestone Mar 25, 2019
@noirbizarre noirbizarre requested a review from a team March 25, 2019 15:06
@noirbizarre noirbizarre mentioned this pull request Mar 25, 2019
Closed
@noirbizarre noirbizarre merged commit f7bbc65 into opendatateam:master Mar 25, 2019
@noirbizarre noirbizarre deleted the pin-werkzeug-0.14.1 branch March 25, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
bug build performance update
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@noirbizarre @abulte