This repository has been archived by the owner on May 6, 2024. It is now read-only.
Modify jenkins worker task to run the wheel script #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,11 +45,26 @@ | |||
| src=wheel_venv.sh.j2 dest={{ jenkins_home }}/wheel_venv.sh | |||
| owner={{ jenkins_user }} group={{ jenkins_group }} mode=700 | |||
|
|
|||
| # Run the wheel_venv.sh script for the first time | |||
| # This was previously done in the Jenkins global | |||
There was a problem hiding this comment.
Does this need to be removed from the global init or does it still make sense to run it there as well?
There was a problem hiding this comment.
It should be removed. Won't cause problems if it's not, just it is redundant will cause the workers to take more time to spin up. I will remove it at the same time as I update it to the new AMI that I create after this PR gets merged.
There was a problem hiding this comment.
huh, for some reason I thought we were dropping that as a template file for the worker role but that doesn't seem to be the case.
|
👍 |
jzoldak
pushed a commit
that referenced
this pull request
Apr 30, 2014
Modify jenkins worker task to run the wheel script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to populate the python virtualenv.
I didn't realize this was being done by the Jenkins master config, and needs to be moved here when I submitted #1049.
Needed to get edx-platform/pull/3498 working, though it can be merged independently.