Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Correct when statement for git prune #1803

Merged
merged 1 commit into from
Jan 28, 2015
Merged

Conversation

singingwolfboy
Copy link
Contributor

git_dir.isdir is never defined, even if /edx/app/edxapp/edx-platform/.git exists and is a directory.

@fredsmith
Copy link
Contributor

👍

singingwolfboy added a commit that referenced this pull request Jan 28, 2015
Correct when statement for git prune
@singingwolfboy singingwolfboy merged commit 582ac66 into master Jan 28, 2015
@singingwolfboy singingwolfboy deleted the db/dont-skip-git-prune branch January 28, 2015 19:07
@@ -46,7 +46,7 @@
notify:
- "restart edxapp"
- "restart edxapp_workers"
when: git_dir.stat.exists and (git_dir.isdir is defined) and git_dir.stat.isdir
when: git_dir.stat.exists and git_dir.stat.isdir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is a typo and the actual correction should be git_dir.stat.isdir is defined, gitdir.stat.isdir is not defined when the location is not a directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants