fix: update LTI XBlock to fix DarkLangMiddleware issue #30716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Names and Roles + Grades for LTI 1.3. For details, see: openedx/xblock-lti-consumer#261 This pulls from the 3.4.7 release of lti-consumer-xblock (the nutmeg branch backport), not from the latest 4.2.2 (which was too risky since it had many unrelated changes).
kdmccormick
approved these changes
Jul 8, 2022
|
If this fix is urgent, could you please open a tutor PR to cherry pick the change on top of nutmeg.1 in the openedx Docker image? |
ormsbee
pushed a commit
to ormsbee/tutor
that referenced
this pull request
Jul 8, 2022
The actual merge of this into open-release/nutmeg.master is here: openedx/edx-platform#30716
ormsbee
pushed a commit
to ormsbee/tutor
that referenced
this pull request
Jul 8, 2022
The actual merge of this into open-release/nutmeg.master is here: openedx/edx-platform#30716
regisb
pushed a commit
to overhangio/tutor
that referenced
this pull request
Jul 8, 2022
The actual merge of this into open-release/nutmeg.master is here: openedx/edx-platform#30716
ormsbee
pushed a commit
to ormsbee/tutor
that referenced
this pull request
Jul 9, 2022
- [Bugfix] Build openedx-dev Docker image even when the host user is root, for instance on Windows. (by @regisb) - [Bugfix] Patch nutmeg.1 release with [LTI 1.3 fix](openedx/edx-platform#30716). (by @ormsbee) - [Improvement] Make it possible to override k8s resources in plugins using `k8s-override` patch. (by @foadlind)
regisb
pushed a commit
to overhangio/tutor
that referenced
this pull request
Jul 9, 2022
- [Bugfix] Build openedx-dev Docker image even when the host user is root, for instance on Windows. (by @regisb) - [Bugfix] Patch nutmeg.1 release with [LTI 1.3 fix](openedx/edx-platform#30716). (by @ormsbee) - [Improvement] Make it possible to override k8s resources in plugins using `k8s-override` patch. (by @foadlind)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Names and Roles + Grades for LTI 1.3. For details, see:
openedx/xblock-lti-consumer#261
This pulls from the 3.4.7 release of lti-consumer-xblock (the nutmeg
branch backport), not from the latest 4.2.2 (which was too risky since
it had many unrelated changes).