Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Make sass compliation agnostic to node_modules location #31583

Closed
wants to merge 20 commits into from
Closed

[wip] Make sass compliation agnostic to node_modules location #31583

wants to merge 20 commits into from

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Jan 17, 2023 •
edited
Loading

This was referenced Jan 17, 2023
Closed
Closed
Closed
Closed
kdmccormick and others added 20 commits January 26, 2023 16:17
@kdmccormick
refactor: build: reimplement compile_sass as a shell script
52d38ef 
TODO details

Part of openedx-unsupported/wg-developer-experience#150
@kdmccormick
squash: add sh command to paver; move sh into assets folder
9128cf0
@kdmccormick
squash: more arguments for compile-sass.sh
6a93016
@kdmccormick
squash: more flags, generalizing to watchers (wip)
4584535
@kdmccormick
squash: use find+xargs+sassc; write most of the logic; passes shellcheck
728d7e0
@kdmccormick
squash: remove unused 'common' code paths
3b8f11a
@kdmccormick
squash: fix: no quotes around include-path
8b59c60
@kdmccormick
squash: rtl support (WIP)
175157e
@kdmccormick
squash: remove --source-comments so we can use libsass==0.10
cf0182c
@kdmccormick
squash: make script work on multiple themes + systems
ccaf14a 
currently failing on the red-theme
@kdmccormick
squash: fix compile_dir logic
9ac58f9
@kdmccormick
squash: improve output
6356865
@kdmccormick
squash: more output improvements && rtlcss enable
546e963
@kdmccormick
squash: extract dir compilation into script
6e005c9
@kdmccormick
squash: compile-sass -> compile-scss
ee2e87f
@kdmccormick
squash: work on output & watching
21ffb65
@kdmccormick
squash: wip: updating pavelib/assets.py
e02a4e5
@kdmccormick
squash: make pavelib/assets wrapper more concise
760f9b3
@kdmccormick
squash: remove watch from compile-scss
b2ca4e4
@kdmccormick
squash: clean up scss scripts. I think they works?
bf8281a
@kdmccormick
Copy link
Member Author

kdmccormick commented Feb 8, 2023 •
edited
Loading

Closing in favor of #31725

@kdmccormick kdmccormick closed this Feb 8, 2023
@kdmccormick kdmccormick deleted the kdmccormick/compile-sass-sh branch February 8, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kdmccormick