Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: mfe_context response to serialize object keys to camelcase #31930

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

shahbaz-shabbir05
Copy link
Contributor

@shahbaz-shabbir05 shahbaz-shabbir05 commented Mar 15, 2023

This pull request modifies the serialization of the back-end response by converting the keys of objects to camelCase. By making this change, we can avoid the need to convert the keys to camelCase on the front-end and ensures that all related unit tests have been updated accordingly.
In order to prevent compatibility issues, it is necessary to remove any front-end code that converts keys from snake_case to camelCase format where it is required.

Ticket: VAN-1311

Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question that I asked, otherwise looks good.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

mubbsharanwar added a commit that referenced this pull request Aug 22, 2023
* refactor: mfe_context response to serialize object keys to camelcase (#31930)

* test: add tests for MFE Context API serializser (#32179)

* fix: empty pipelineUserDetail object

pipelineUserDetail object should be empty when pipeline is not running

---------

Co-authored-by: Shahbaz Shabbir <32649010+shahbaz-arbisoft@users.noreply.github.com>
shURenZHOUluxun pushed a commit to EduTrigger/edx-platform that referenced this pull request Jan 3, 2024
* refactor: mfe_context response to serialize object keys to camelcase (openedx#31930)

* test: add tests for MFE Context API serializser (openedx#32179)

* fix: empty pipelineUserDetail object

pipelineUserDetail object should be empty when pipeline is not running

---------

Co-authored-by: Shahbaz Shabbir <32649010+shahbaz-arbisoft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants