feat: allow course entitlements REST API to be filtered on course_uuid #32305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
force-pushed
the
cpappas/PON-158
branch
from
ff262a8
to
ec788e6
Compare
| @@ -40,7 +40,8 @@ class CourseEntitlementFilter(filters.FilterSet): | |||
|
|
|||
| uuid = UUIDListFilter() | |||
| user = filters.CharFilter(field_name='user__username') | |||
| course_uuid = UUIDListFilter(field_name='course_uuid') | |||
There was a problem hiding this comment.
Will query params character length be an issue if there is a large courseUUID list?
There was a problem hiding this comment.
potentially, yes
| for entitlement in entitlements[0:3] | ||
| } | ||
| # Create a 2nd entitlement for one of the ones to filter on | ||
| CourseEntitlementFactory.create(user=self.user, course_uuid=str(entitlements[0].course_uuid)) |
There was a problem hiding this comment.
I did not get it. Could you please elaborate on why are we creating another entry with the same course UUID?
There was a problem hiding this comment.
I wanted the test set to seem more realistic, because in the wild we can potentially encounter a response that has entitlements with the same course_uuid
shafqatfarhan
approved these changes
May 26, 2023
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
openedx#32305) * feat: allow course entitlements REST API to be filtered on course_uuid * feat: add field to filter out entitlements with null expired_at values * chore: update tests
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
openedx#32305) * feat: allow course entitlements REST API to be filtered on course_uuid * feat: add field to filter out entitlements with null expired_at values * chore: update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.