fix: save scroll position on exit from video xblock fullscreen mode

[ihor-romaniuk]

This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.

Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.

Dependent PR to MFE Learning:
This MR openedx/edx-platform#31061 must be merged with this MR.

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.21 ⚠️

Comparison is base (340580c) 87.25% compared to head (65ca026) 87.04%.

❗ Current head 65ca026 differs from pull request most recent head 6f5d9fc. Consider uploading reports for the commit 6f5d9fc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   87.25%   87.04%   -0.21%     
==========================================
  Files         253      253              
  Lines        4400     4386      -14     
  Branches     1112     1111       -1     
==========================================
- Hits         3839     3818      -21     
- Misses        547      549       +2     
- Partials       14       19       +5     

Impacted Files	Coverage Δ
src/courseware/course/sequence/Unit.jsx	84.37% <100.00%> (+1.76%)	⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[itsjeyd]

@ihor-romaniuk Thank you for your contribution! Please let us know when it is ready for review.

[ihor-romaniuk]

@itsjeyd It's ready for review. Thanks in advance.

[itsjeyd]

Hey @ProductRyan, the edx-platform PR that corresponds to this PR was flagged for product review, so I was wondering if your team would like to have a look at this PR as well (before we put it up for engineering review)? Please let me know.

[itsjeyd]

CC @jmakowski1123

[itsjeyd]

For reference, going forward the primary communication place for PRs related to this issue will be #981 (as mentioned here).

[itsjeyd]

Hey @ihor-romaniuk, just checking in to see where you're at with this work? It looks like the owning team is ready to take this PR through product review. So if you could follow up on the latest comments from openedx/platform-roadmap#229 (as well as #981 and #982), that would be great.

CC @ProductRyan @arbrandes

[itsjeyd]

Hey @ihor-romaniuk, while this is waiting for engineering review it might make sense to address codecov failures here (and backport relevant changes to #982 when done).

[itsjeyd]

@ihor-romaniuk A friendly ping about my previous comment.

[ihor-romaniuk]

Hi @itsjeyd. Sorry for delay. Tests were updated and it's ready for review.

[itsjeyd]

Hey @ihor-romaniuk, no worries and thanks for the update.

@mattcarter This PR, as well as the corresponding backports for Olive (#1077), Nutmeg (#981), and Maple (#982) are ready for engineering review by Aurora.

[itsjeyd]

@mattcarter A friendly ping on this set of PRs ⬆️. Would it be possible to get them lined up for engineering review soon?

[itsjeyd]

@ihor-romaniuk You might already be aware of it but just in case, a quick heads-up that your PR has been added to this review queue.

[leangseu-edx]

LGTM 👍

[leangseu-edx]

@ihor-romaniuk It seems the test is stuck. I can make squash the commit and re-push the pr. I don't have permission to make the change because this pr is based on the fork repo.

[itsjeyd]

Thanks @leangseu-edx!

@ihor-romaniuk Could you please follow up on the comment above so we can get a green build and merge this PR?

[ihor-romaniuk]

Hi @leangseu-edx @itsjeyd.
Everything was fixed. Please take a look one more.

[openedx-webhooks]

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.