Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitCommit in commands package not being updated at build time #62

Closed
johnmccabe opened this issue Sep 2, 2017 · 2 comments
Closed

GitCommit in commands package not being updated at build time #62

johnmccabe opened this issue Sep 2, 2017 · 2 comments

Comments

@johnmccabe
Copy link
Contributor

Expected Behaviour

This results in the following output for a brew installed CLI:

$ ./faas-cli version
Git Commit: thisisavalidsha

Current Behaviour

Following the merge of #50 and the move of the GitCommit variable from the old main package rather than commands package this commit SHA isn't getting populated.

This results in the following output:

$ ./faas-cli version
Git Commit:

Possible Solution

Steps to Reproduce (for bugs)

  1. Download the current 0.4.9 release, or build locally using build_redist.sh and run ./faas-cli version

Context

Your Environment

  • Docker version docker version (e.g. Docker 17.0.05 ):
    n/a

  • Are you using Docker Swarm or Kubernetes (FaaS-netes)?
    n/a

  • Operating System and version (e.g. Linux, Windows, MacOS):
    MacOS

  • Link to your project or a code example to reproduce issue:
    n/a

@johnmccabe
Copy link
Contributor Author

spotted by @ems5311 in the #faas channel on Slack

@alexellis
Copy link
Member

Fixed by #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants