Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label support #184

Merged
merged 3 commits into from
Oct 23, 2017
Merged

Add label support #184

merged 3 commits into from
Oct 23, 2017

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Oct 22, 2017

Signed-off-by: Alex Ellis alexellis2@gmail.com

Description

Adds label support for functions

Motivation and Context

Needed for openfaas/faas#325

How Has This Been Tested?

Tested with openfaas/faas#325 - via:

  • YAML
  • YAML plus arguments --label
  • Via arguments only --label

This change has a back-end fix with swarm, but Kubernetes support will come in a follow-up PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant