Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get.sh to determine latest full release from Github #37

Merged
merged 1 commit into from
Aug 19, 2017
Merged

Update get.sh to determine latest full release from Github #37

merged 1 commit into from
Aug 19, 2017

Conversation

johnmccabe
Copy link
Contributor

Description

This PR updates the one-line installer get.sh to use the latest full release from Github rather than use a hard-coded version string.

Draft releases and prereleases are not returned by the endpoint used to determine the version.

Motivation and Context

Currently get.sh uses a hardcoded version, the script hosted on https://cli.openfaas.com pulls in an outdated version 0.4.5b

  • I have raised an issue to propose this change

How Has This Been Tested?

Tested on Linux (Alpine, Fedora, Ubuntu, CentOS), and OSX.

For example:

$ sudo ./get.sh
Password:
Getting package https://github.com/alexellis/faas-cli/releases/download/0.4.7/faas-cli-darwin
Attemping to move faas-cli to /usr/local/bin
New version of faas-cli installed to /usr/local/bin

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This commit updates the one-line installer `get.sh` to use the latest
full release from Github rather than use a hard-coded version string.

Draft releases and prereleases are not returned by the endpoint used to
determine the version.

Signed-off-by: John McCabe <john@johnmccabe.net>
@alexellis
Copy link
Member

I think version pinning is more predictable which is why it's hard-coded, but let's try this suggestion to see how it goes.

@alexellis
Copy link
Member

Thanks for the change. Merged and applied to server.

@alexellis alexellis closed this Aug 19, 2017
@alexellis alexellis reopened this Aug 19, 2017
@alexellis alexellis merged commit e413d42 into openfaas:master Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants