Make gofmt fail builds

[itscaro]

Description

• gofmt to break local and CI builds

Motivation and Context

• I have raised an issue to propose this change (Proposal: Do a gofmt verification before build #95)

How Has This Been Tested?

Types of changes

Build changes

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[alexellis]

Hi @itscaro,

This is an interesting idea, thanks for looking into it. We're still using Golang 1.8 across the board until our main dependencies also move to Golang 1.9. I.e. Docker and Kubernetes. The reason the pull request template requires everyone to raise a proposal for significant changes is so that folks don't end up working on things which we can't include yet.

I'd be happy to take the change for gofmt if you can re-push it in a generic way - i.e. run it via the build_redist.sh file?

[itscaro]

Since the go in travis is only used to do go get that why I bump it up directly from 1.7 to 1.9

I moved the gofmt verification into build.sh and build_redist.sh

[itscaro]

@alexellis should we use Makefile?

itscaro@74f8178

[alexellis]

So let's start at the beginning again.

Can you add your "exit 1" code to these files?

https://github.com/alexellis/faas-cli/blob/master/Dockerfile#L7

https://github.com/alexellis/faas-cli/blob/master/Dockerfile.redist

[itscaro]

@alexellis is it ok like this?

[ghost]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

[alexellis]

Merging! Thank you @itscaro for your patience on this one. We really value your input on the project, keep it up.