Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade client-go 1.28, codegen and CRD #66

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Oct 20, 2023

Description

Upgrade client-go 1.28, codegen and CRD

Motivation and Context

Maintenance task to update to the latest versions of the Kubernetes SDKs/tools and APIs.

Also adds a standard "conditions-based" status object to the FunctionIngress to be populated later.

How Has This Been Tested?

Building the code locally and within Docker.

Then, ran out of cluster, after applying the CRD:

The Ingress record was created for the sample object ./examples/nodeinfo-ingress.yaml, plus a warning that may need later work:

I1020 14:20:08.391934 3319312 main.go:51] Starting FunctionIngress controller version: latest-dev commit: local-dev
I1020 14:20:08.394413 3319312 controller.go:70] Setting up event handlers
I1020 14:20:08.394456 3319312 core.go:72] Waiting for informer caches to sync
I1020 14:20:08.494815 3319312 core.go:77] Starting workers
I1020 14:20:08.494842 3319312 core.go:83] Started workers
I1020 14:20:26.381036 3319312 controller.go:116] Creating Ingress for: nodeinfo
W1020 14:20:26.452110 3319312 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead

Types of changes

Updates to libraries

Impact to existing users

None expected.

Fixes: #58

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Ingress has now been in the v1/networking space for a
significant period of time, and the old code whilst very clever
is no longer required.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis merged commit 9279e05 into master Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant