Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kind in TLS Spec #9

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

affix
Copy link
Contributor

@affix affix commented Jul 29, 2019

Signed-off-by: Keiran Smith contact@keiran.scot

Add support for ClusterIssuer by following the issuerRef Kind

Description

Uses a switch to determine the correct annotation based on TLS issuerRef

Motivation and Context

Fixes issue #8

How Has This Been Tested?

Tested on personal cluster

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Impact to existing users

Nothing

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Keiran,

Thanks for covering this.

One further change will be needed to local README and to add a unit test, plus one PR to the openfaas/docs repo.

Thanks,

Alex

Signed-off-by: Keiran Smith <contact@keiran.scot>
@affix
Copy link
Contributor Author

affix commented Jul 30, 2019

@alexellis Requirements met :)

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test after the merge of #7 so that we don't cross wires with Marcus

@alexellis alexellis merged commit 1372061 into openfaas:master Jul 30, 2019
@alexellis
Copy link
Member

Thank you @affix 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants