Update testing matrix #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-wags
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Looks great. Before merging, could you add some representation of this table to docs/developing.rst? I'm dumb and don't know whether a markdown-formatted table can be put in a .rst file (maybe @Yoshanuikabundi does?), but I've used this tool to great success before.
|
Turns out rST has its own table syntax, which seems no more powerful than Markdown but significantly more finicky (surprise?). I managed to get an acceptable solution as per Pycharm and a local build (thanks for the instructions in #863, by the way).
|
9 tasks
|
Looks great. Thanks for digging into this, @mattwthompson. Merge whenever you're ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to go now that 0.9.1 is released
The upcoming toolkit release 0.9.1 will be the last release to support Python 3.6. Many other scientific packages have already dropped it (NEP 29 schedule this change for last summer!) and we are currently unaware of any users that require 3.6 support.
We agreed on the following matrix
Note that OpenEye has not published Python 3.9 builds for their toolkits link, so RDKit-only is the only option at the moment for 3.9. The 3.8 builds are being trimmed in order to get CI running a little quicker; all Python versions, each combination of toolkits, and both Linux and macOS are still being tested, just not all combinations of each.