Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keba] Remove org.apache.commons #14409

Merged
merged 9 commits into from
Oct 21, 2023
Merged

[keba] Remove org.apache.commons #14409

merged 9 commits into from
Oct 21, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 16, 2023

  • Remove dependency on apache.commons

Untested, minor refactoring from only from code perspective

Test jar 4.1.0: https://1drv.ms/u/s!AnMcxmvEeupwjq5ZXev_AwpK25Rrvg?e=jQ1Jop

Signed-off-by: lsiepel <leosiepel@gmail.com>
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label May 9, 2023
@lsiepel
Copy link
Contributor Author

lsiepel commented Jul 29, 2023

@kgoderis Could you perform a review/test?

@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Aug 1, 2023
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged rebuild Triggers Jenkins PR build labels Oct 15, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a null annotation warning.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 21, 2023

Fixed the introduced warning and fixed some others.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 3ed22b4 into openhab:main Oct 21, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Oct 21, 2023
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
@lsiepel lsiepel deleted the keba-apache branch November 11, 2023 13:51
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants