Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oceanic] Remove org.apache.common #15332

Merged
merged 6 commits into from
Oct 21, 2023
Merged

[oceanic] Remove org.apache.common #15332

merged 6 commits into from
Oct 21, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 29, 2023 •
edited
Loading

  • Remove dependency on apache.commons

Untested, minor refactoring, only from code perspective

Test jar 4.1.0 : https://1drv.ms/u/s!AnMcxmvEeupwjq5Xy-CEfgI_nPIfLg?e=Dt3BIJ

@lsiepel
Remove apache.commons
057c05d 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from a team July 29, 2023 20:53
@lsiepel lsiepel requested a review from kgoderis as a code owner July 29, 2023 20:53
@jlaur jlaur added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jul 29, 2023
@lsiepel lsiepel mentioned this pull request Jul 29, 2023
Open
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Aug 1, 2023
@lsiepel lsiepel mentioned this pull request Aug 1, 2023
Closed
26 tasks
@lsiepel
Merge branch 'openhab:main' into oceanic-apache-removal
10cfb6a
@lsiepel
adapt to core StringUtils
309b9b3 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Fix import
b31910a 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. work in progress A PR that is not yet ready to be merged labels Oct 15, 2023
@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 16, 2023
jlaur
jlaur approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lolodomo
Copy link
Contributor

@jlaur : I see you approved the PR. Are we waiting for something to merge it?

@jlaur
Copy link
Contributor

jlaur commented Oct 19, 2023

I see you approved the PR. Are we waiting for something to merge it?

I was waiting for the build, but then forgot. I see now that it has introduced null annotation warnings.

jlaur
jlaur requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comment.

@lsiepel
fix null comment
305f0e0 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Oct 20, 2023

While at it i tried to fix some more null warnings.

@lsiepel lsiepel requested a review from jlaur October 21, 2023 11:40
jlaur
jlaur requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added two very minor comments for additional improvement opportunities spotted, but since you only changed code close by, this is completely optional. 🙂

...c/src/main/java/org/openhab/binding/oceanic/internal/handler/NetworkOceanicThingHandler.java Outdated Show resolved Hide resolved
....oceanic/src/main/java/org/openhab/binding/oceanic/internal/handler/OceanicThingHandler.java Show resolved Hide resolved
@lsiepel
Review comments
d9775b8 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from jlaur October 21, 2023 18:39
jlaur
jlaur approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7975afb into openhab:main Oct 21, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Oct 21, 2023
@lsiepel lsiepel deleted the oceanic-apache-removal branch October 21, 2023 21:04
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@lsiepel @querdenker2k
[oceanic] Remove org.apache.common (openhab#15332)
1b34564 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[oceanic] Remove org.apache.common (openhab#15332)
2d9747b 
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lsiepel @lolodomo @jlaur