[homekit] Allow configuring thermostat modes via metadata #17056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example, if it's a water heater that's always in heat mode, so you don't have to create dummy items for the characteristics this also adds the infrastructure necessary to use metadata characteristics as mandatary characteristics it also adds TemperatureUnit as a characteristic the user can provide, and support TargetRelativeHumidity characteristic for Thermostat Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/homekit-integration-beta/157125/1 |
jlaur
changed the title
yfre
approved these changes
Jul 14, 2024
lsiepel
requested changes
Jul 14, 2024
...mekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitAccessoryFactory.java
Outdated
Show resolved
Hide resolved
...mekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitAccessoryFactory.java
Outdated
Show resolved
Hide resolved
...n/java/org/openhab/io/homekit/internal/accessories/HomekitMetadataCharacteristicFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Cody Cutrer <cody@cutrer.us>
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example, if it's a water heater that's always in heat mode, so you don't have to create dummy items for the characteristics
this also adds the infrastructure necessary to use metadata characteristics as mandatary characteristics
it also adds TemperatureUnit as a characteristic the user can provide, and support TargetRelativeHumidity characteristic for Thermostat