Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added /resource/smart_scene API #35

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

a-stangl
Copy link
Contributor

@a-stangl a-stangl commented Aug 6, 2024

Added the API endpoints and schemas for "Dynamic Scenes" (aka Smart Scenes).

@a-stangl
Copy link
Contributor Author

a-stangl commented Aug 6, 2024

I haven't seen any schemas where the object properties have been declared required. In case no required properties should be declared, please let me know and I change this.
I guess if validation regarding required properties is needed, it should be done globally and not just for the smart_scene endpoint(s). Therefore, reverting this.

I manually compared the generated Redoc documentation with the one from the Hue CLIP API references (here & here), and I think this should now be ready for review.

@a-stangl a-stangl force-pushed the feat/smart-scenes branch 3 times, most recently from 0ec3d87 to c64c521 Compare August 6, 2024 15:30
@a-stangl a-stangl marked this pull request as ready for review August 6, 2024 15:38
@thibauult
Copy link
Collaborator

Hi @a-stangl, thanks a lot for your contribution!

I guess if validation regarding required properties is needed, it should be done globally and not just for the smart_scene endpoint(s). Therefore, reverting this.

Well, I must admit here that I haven´t been cautious with this from the very beginning of the project. I believe it should have been done globally. I am totally fine if you want to re-introduce it.

@thibauult thibauult self-requested a review August 6, 2024 16:54
@thibauult thibauult added the enhancement New feature or request label Aug 6, 2024
@a-stangl
Copy link
Contributor Author

a-stangl commented Aug 7, 2024

All right, @thibauult, I added the required properties where it makes sense and where I don't have to change too many global things.

@thibauult thibauult merged commit 66b4f5c into openhue:main Aug 7, 2024
1 check passed
@thibauult
Copy link
Collaborator

Thanks again @a-stangl for your contribution 🙏

The Smart Scene API has been published and is now available from the public specification.

@a-stangl a-stangl deleted the feat/smart-scenes branch August 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants