Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple configurations / changeable platform. + FREE BUILD #137

Merged
merged 9 commits into from
May 3, 2023

Conversation

FlorianKirmaier
Copy link
Contributor

Similar to the other PullRequest,
Only took the idea of the other pull requests.

It would be great if this (or the other pull requests) could be merged!

Until then, feel free to use my fork:

repositories {
  gradlePluginPortal()
  maven {
    url "https://sandec.jfrog.io/artifactory/repo"
  }
}
dependencies {
  classpath 'org.openjfx:javafx-plugin:0.0.14-SNAPSHOT-FORK'
}

Updated gradle version slightly to avoid various minor issues
@FlorianKirmaier FlorianKirmaier changed the title Added multiple configurations / changeable platform. Added multiple configurations / changeable platform. + FREE BUILD Dec 19, 2022
@abhinayagarwal
Copy link
Collaborator

Hi @FlorianKirmaier,

I feel configuration is superseded by configurations property. IMO, only latter should be enough.

@FlorianKirmaier
Copy link
Contributor Author

I kept the setConfiguration method to make the PR was supposed to be compatible with the old code.

Thank you for looking into the PR!

Didn't know it was possible to continue to work on the branch of a PR, interesting!

Copy link
Collaborator

@jperedadnr jperedadnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants