Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add networkType kubernetes-ingress #54

Merged
merged 3 commits into from
May 22, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

Signed-off-by: ChrisLiu <chrisliu1995@163.com>
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #54 (d2a2aa8) into master (e888ec0) will increase coverage by 2.87%.
The diff coverage is 52.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   26.28%   29.15%   +2.87%     
==========================================
  Files          16       17       +1     
  Lines        1990     2240     +250     
==========================================
+ Hits          523      653     +130     
- Misses       1425     1544     +119     
- Partials       42       43       +1     
Flag Coverage Δ
unittests 29.15% <52.00%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudprovider/kubernetes/ingress.go 52.00% <52.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: ChrisLiu <chrisliu1995@163.com>
Signed-off-by: ChrisLiu <chrisliu1995@163.com>
@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 07a26a9 into openkruise:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants