Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resourcedistribution generator #69

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

dong4325
Copy link
Contributor

No description provided.

@kruise-bot
Copy link

Welcome @dong4325! It looks like this is your first PR to openkruise/kruise-tools 🎉

@dong4325 dong4325 force-pushed the master branch 6 times, most recently from 4955b4a to 20c417b Compare August 30, 2022 07:29
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add README doc and UT test cases.

Signed-off-by: dong <dong4325@126.com>
@dong4325
Copy link
Contributor Author

Please add README doc and UT test cases.

Ok, I've added them

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hantmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit ba2f3db into openkruise:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants