Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log-container-sidecarset.md 格式问题 #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update log-container-sidecarset.md 格式问题 #168

wants to merge 1 commit into from

Conversation

huo-yuan-ja
Copy link

No description provided.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @huo-yuan-ja! It looks like this is your first PR to openkruise/openkruise.io 🎉

furykerry
furykerry reviewed Mar 1, 2024
View reviewed changes
docs/best-practices/log-container-sidecarset.md
volumes:
- configMap:
name: filebeat-config
#hzj change
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz remove this comment

furykerry
furykerry reviewed Mar 1, 2024
View reviewed changes
docs/best-practices/log-container-sidecarset.md
@@ -106,7 +106,7 @@ spec:
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
fieldPath: metadata.namespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz correct valueFrom field as well, its indentation is also incorrect.

@furykerry
Copy link
Member

plz also sign your commit

@furykerry
Copy link
Member

plz also correct the Chinese document in i18n/zh/docusaurus-plugin-content-docs/current/best-practices/log-container-sidecarset.md

@kruise-bot
Copy link

@huo-yuan-ja: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furykerry furykerry furykerry left review comments

@FillZpp FillZpp Awaiting requested review from FillZpp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-rebase size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huo-yuan-ja @kruise-bot @furykerry