Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize webhook patchResponse function #165

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Jul 17, 2023

Ⅰ. Describe what this PR does

There is a risk that the current webhook patch method will cause some fields to be lost if the rollout references a low version of the api. For example, k8s 1.26 adds a new field topologySpreadConstraint.minDomains, the field will be lost after the webhook.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 17, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #165 (1c7ada9) into master (72e1c0b) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   43.44%   43.34%   -0.10%     
==========================================
  Files          50       50              
  Lines        5361     5373      +12     
==========================================
  Hits         2329     2329              
- Misses       2635     2647      +12     
  Partials      397      397              
Flag Coverage Δ
unittests 43.34% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bhook/workload/mutating/workload_update_handler.go 31.80% <0.00%> (-1.41%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Jul 18, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2986258 into openkruise:master Jul 18, 2023
17 checks passed
@zmberg zmberg deleted the optimize-webhook-patch branch July 18, 2023 05:24
zmberg added a commit that referenced this pull request Jul 18, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants