Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates pydantic to resolve #221 #229

Closed
wants to merge 2 commits into from
Closed

Conversation

kammoh
Copy link

@kammoh kammoh commented Mar 29, 2022

update pydantic (and other dependencies, including test, doc, dev, etc)

Description (e.g. "Related to ...", etc.)

Fixes #221

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

update other dependencies, including dev depenedencies
Copy link
Contributor

@perrinjerome perrinjerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good ( this is also what I felt in #148 (comment) )

I left a few remarks, I don't know if it's OK for me to click approve, I'm just an external contributor

setup.cfg Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@perrinjerome perrinjerome mentioned this pull request Apr 1, 2022
8 tasks
@@ -39,16 +45,18 @@ exclude =

[options.extras_require]
ws =
websockets==9.*
websockets~=10.2
Copy link
Collaborator

@alcarney alcarney Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think websockets 10.x drops support for Python 3.6, (see this comment) this might have to stay on 9.x for now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's okay to drop 3.6 support as well for pygls? Would be cool to see this PR get forward.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, though I think that call probably lies with @danixeee or @dgreisen

Copy link

@Bobronium Bobronium May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to update websockets to support python 3.10?

If not, I'd propose doing it in a separate PR, while merging this first to address compatibility issues.

Then we can reason about whether dropping python3.6 is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why Pydantic?
5 participants