-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates pydantic to resolve #221 #229
Conversation
update other dependencies, including dev depenedencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good ( this is also what I felt in #148 (comment) )
I left a few remarks, I don't know if it's OK for me to click approve, I'm just an external contributor
@@ -39,16 +45,18 @@ exclude = | |||
|
|||
[options.extras_require] | |||
ws = | |||
websockets==9.* | |||
websockets~=10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think websockets 10.x
drops support for Python 3.6, (see this comment) this might have to stay on 9.x
for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's okay to drop 3.6 support as well for pygls? Would be cool to see this PR get forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to update websockets
to support python 3.10?
If not, I'd propose doing it in a separate PR, while merging this first to address compatibility issues.
Then we can reason about whether dropping python3.6 is a good idea.
update pydantic (and other dependencies, including test, doc, dev, etc)
Description (e.g. "Related to ...", etc.)
Fixes #221
Code review checklist (for code reviewer to complete)