process ready items always even if others fail #1229
Conversation
.eslintrc.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| ], | |||
| "linebreak-style": [ | |||
| "error", | |||
| "unix" | |||
| "windows" | |||
There was a problem hiding this comment.
This needs to stay "unix". Is your editor not respecting the linebreak style that's already in the files?
There was a problem hiding this comment.
eslint kept complaining. I work on windows. Will set it back to Unix.
|
is there something else I should do now? still a noob |
|
@endevea Nope... just didn't have a chance to get to it earlier. Looking good :) Thank you again for making this fix! Regarding the eslint thing, you should be able to set your text editor to respect the line break style that's already in the files, regardless of what OS you're on. Which text editor are you using, out of curiosity? |
|
VS code is the text editor. However, eslint complained about CRLF/LF in all files when building even before any editing was done. It must be a git setting of mine. |
|
Interesting... yes, sounds like git is somehow converting the line endings! |
Fixes issue #1218.