Check that zoom reference point is valid before using it #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! Could you add a similar check to the part of zoomBy() that uses refPoint? |
|
New commit should do the same check before trying to rotate the refPoint in zoomBy, let me know if you see anything else |
|
Awesome, thank you! |
iangilman
added a commit
that referenced
this pull request
Oct 8, 2013
Check that zoom reference point is valid before using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a case where the final division in calculating the reference point turned into an effective divide-by-zero (floating point precision error, mumble mumble), resulting in an invalid reference point and images blanking out due to the invalid reference point. This commit simply checks that the reference point isn't NaN before using it.