Correct IIIF tile source to use canonical syntax #586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IIIF canonical syntax is defined here: http://iiif.io/api/image/2.0/#canonical-uri-syntax. It was added in the 2.0 release of the spec in order to facilitate the creation of static image collections using a common syntax that clients would expect and servers could expose using only a file system.
OpenSeadragon does not presently use
full
when requesting the whole image (at lower levels) from IIIF 2.0-compliant servers. Instead it uses0,0,<full_width>,<full_height>
. Functionally these are the same, but it breaks static collections and optimized servers.Specifically,
this.tile_width
andthis.tile_height
(here) were not defined for IIIF 2.0 requests, and so theelse
block was always executed./cc @azaroth42