Skip to content

Commit

Permalink
[Tests] update TODOs with [RENAMEME] and ref to .com
Browse files Browse the repository at this point in the history
PR comment to include RENAMEME for easy grepping and update a ref
to opensearch.com to opensearch.co so that it is easier to grep while
renaming. Then had to regenerate the snapshots.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
  • Loading branch information
kavilla committed Mar 26, 2021
1 parent b93ef34 commit 4fcc7bb
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/osd-apm-config-loader/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const getDefaultConfig = (isDistributable: boolean): ApmAgentConfig => {
return {
active: false,
serverUrl: 'https://f1542b814f674090afd914960583265f.apm.us-central1.gcp.cloud.es.io:443',
// TODO: serverUrl
// TODO: [RENAMEME] Update serverUrl and secretToken if we have replacements
// The secretToken below is intended to be hardcoded in this file even though
// it makes it public. This is not a security/privacy issue. Normally we'd
// instead disable the need for a secretToken in the APM Server config where
Expand Down
2 changes: 1 addition & 1 deletion src/core/public/doc_links/doc_links_service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('DocLinksService#start()', () => {
const api = service.start({ injectedMetadata });
expect(api.DOC_LINK_VERSION).toEqual('test-branch');
expect(api.links.opensearchDashboards).toEqual(
'https://www.opensearch.com/guide/en/kibana/test-branch/index.html'
'https://www.opensearch.co/guide/en/kibana/test-branch/index.html'
);
});
});
3 changes: 1 addition & 2 deletions src/core/public/doc_links/doc_links_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ export class DocLinksService {
public setup() {}
public start({ injectedMetadata }: StartDeps): DocLinksStart {
const DOC_LINK_VERSION = injectedMetadata.getOpenSearchDashboardsBranch();
// const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.co/';
const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.com/';
const OPENSEARCH_WEBSITE_URL = 'https://www.opensearch.co/';
const OPENSEARCH_DOCS = `${OPENSEARCH_WEBSITE_URL}guide/en/elasticsearch/reference/${DOC_LINK_VERSION}/`;

return deepFreeze({
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test('should add `noreferrer` and `nooopener` to unknown links in new tabs', ()
});

// TODO: In @elastic/eui/src/services/url.ts it is unknown if it does not match the regex
// TODO: [renameme] if we fork EUI and update that regex then we can include this test again
// TODO: [RENAMEME] if we fork EUI and update that regex then we can include this test again
xtest('should only add `nooopener` to known links in new tabs', () => {
const component = shallow(
<Markdown openLinksInNewTab={true} markdown="[link](https://www.opensearch.co/cool/path" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import { defaultAlertText } from './default_alert';

// TODO: Ignoring because the defaultAlertText was commented out because it upsells a hosted solution.
// TODO: [RENAMEME] Ignoring because the defaultAlertText was commented out because it upsells a hosted solution.
xdescribe('defaultAlertText', () => {
it('creates a valid MountPoint that can cleanup correctly', () => {
const mountPoint = defaultAlertText(jest.fn());
Expand Down
1 change: 0 additions & 1 deletion src/plugins/share/public/opensearch_dashboards_url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
* under the License.
*/

// TODO: Replace this logic with OpenSearchDashboardsURL once it is available.
// https://github.com/elastic/kibana/issues/64497
export class OpenSearchDashboardsURL {
public readonly path: string;
Expand Down

0 comments on commit 4fcc7bb

Please sign in to comment.