Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Fix display issue. #182

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[Rename] Fix display issue. #182

merged 1 commit into from
Mar 18, 2021

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 18, 2021

Signed-off-by: Anan Zhuang ananzh@amazon.com

Find a minor renaming error in src/core/utils/default_app_categories.ts which will cause navLinks returns undefined category in src/plugins/opensearch_dashboards_overview/publid/plugin.ts

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh changed the title Fix display issue. [Rename] Fix display issue. Mar 18, 2021
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odfe-release-bot
Copy link

✅   DCO Check Passed

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Thanks for the changes.

@mihirsoni mihirsoni merged commit 45b7be7 into opensearch-project:dashboards Mar 18, 2021
@ananzh ananzh deleted the dashboards-new branch March 18, 2021 07:00
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
…ct#182)

disable github workflows running on windows for development (opensearch-project#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
…ct#182)

disable github workflows running on windows for development (opensearch-project#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
…ct#182)

disable github workflows running on windows for development (opensearch-project#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Feb 22, 2024
…ct#182)

disable github workflows running on windows for development (opensearch-project#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
…ct#182)

disable github workflows running on windows for development (opensearch-project#161)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants