[Tests] Update snapshots #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed |
Updated snapshots using yarn test:jest -u. Unit tests do not pass fully in this commit. But this will setup the work for fixing unit tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
update-snapshots
branch
from
bc3c94b
to
5f85d87
Compare
|
✅ DCO Check Passed |
ananzh
reviewed
Mar 23, 2021
packages/osd-config/src/raw/__snapshots__/read_config.test.ts.snap
Outdated
Show resolved
Hide resolved
3 tasks
3 tasks
Elasticsearch reference was missed while updating a config. Updated the config and re-ran the snapshot update command. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed b70caf9 |
boktorbb
suggested changes
Mar 23, 2021
src/core/server/opensearch/legacy/opensearch_client_config.test.ts
Outdated
Show resolved
Hide resolved
src/core/server/opensearch/legacy/opensearch_client_config.test.ts
Outdated
Show resolved
Hide resolved
ananzh
previously approved these changes
Mar 23, 2021
While generating more snapshots more Kibana and Elastic references were caught. Updated the source code and re-ran yarn test:jest -u. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed b16b428 |
kavilla
added a commit
that referenced
this pull request
Mar 24, 2021
* [Tests] Update snapshots Updated snapshots using yarn test:jest -u. Unit tests do not pass fully in this commit. But this will setup the work for fixing unit tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Test] Update config fixture in OSD config Elasticsearch reference was missed while updating a config. Updated the config and re-ran the snapshot update command. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Tests] Update missing kibana and elastic references While generating more snapshots more Kibana and Elastic references were caught. Updated the source code and re-ran yarn test:jest -u. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the snapshots for jest tests. Unit tests shouldn't be passing yet and were not passing prior to this PR. This is to setup work prior to fixing the unit tests.
Snapshots were updated with the following command:
yarn test:jest -u.Issues Resolved
#207
Check List
Signed-off-by: Kawika Avilla kavilla414@gmail.com