[PURIFY][DOCS] Regenerate API docs after rename #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
|
✅ DCO Check Passed a40f8e1 |
kavilla
approved these changes
Apr 5, 2021
boktorbb
reviewed
Apr 5, 2021
| @@ -894,7 +824,7 @@ export type IBasePath = Pick<BasePath, keyof BasePath>; | |||
|
|
|||
| // @public | |||
| export interface IClusterClient { | |||
| readonly asInternalUser: ElasticsearchClient; | |||
| readonly asInternalUser: OpenSearchClient; | |||
There was a problem hiding this comment.
Should this stay as ElasticsearchClient?
There was a problem hiding this comment.
I think it should OpenSearch as it is internal.
Comment on lines
+936
to
+937
| readonly asCurrentUser: OpenSearchClient; | ||
| readonly asInternalUser: OpenSearchClient; |
There was a problem hiding this comment.
Should these stay as ElasticsearchClient?
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 26, 2024
…oject#250) Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 18, 2024
…oject#250) Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Resolves -> #249