Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project level README #258

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Update project level README #258

merged 2 commits into from
Apr 8, 2021

Conversation

boktorbb
Copy link
Contributor

@boktorbb boktorbb commented Apr 8, 2021 •
edited
Loading

Description

Update README with new dashboards run command and add a section for running unit and integration tests

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Update README with new run command and Running Tests section
c517fd1 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb added >Fork docs Improvements or additions to documentation labels Apr 8, 2021
@boktorbb boktorbb added this to the Beta release milestone Apr 8, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed c517fd1

kavilla
kavilla previously approved these changes Apr 8, 2021
View reviewed changes
seanneumann
seanneumann reviewed Apr 8, 2021
View reviewed changes
README.md Show resolved Hide resolved
ananzh
ananzh previously approved these changes Apr 8, 2021
View reviewed changes
seanneumann
seanneumann reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the tests that work up.

Address PR comments
22dc07d 
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
@boktorbb boktorbb dismissed stale reviews from ananzh and kavilla via 22dc07d April 8, 2021 16:51
@odfe-release-bot
Copy link

✅   DCO Check Passed 22dc07d

ananzh
ananzh approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mihirsoni
mihirsoni approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@mihirsoni mihirsoni merged commit af8c3d8 into opensearch-project:main Apr 8, 2021
@mihirsoni mihirsoni mentioned this pull request Apr 9, 2021
Closed
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Feb 28, 2024
@SuZhou-Joe
feat: remove useless code (opensearch-project#258)
8de7956 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirsoni mihirsoni mihirsoni approved these changes

@ananzh ananzh ananzh approved these changes

@seanneumann seanneumann Awaiting requested review from seanneumann

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
Beta release
Development

Successfully merging this pull request may close these issues.
6 participants
@boktorbb @odfe-release-bot @mihirsoni @seanneumann @kavilla @ananzh