[Rename] remove remaining references #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some values were added but should not impact current cuts for the public. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed c72ed43 |
boktorbb
reviewed
May 11, 2021
src/legacy/server/config/schema.js
Outdated
Comment on lines
208
to
210
| emsFileApiUrl: Joi.string().default('https://vector.maps.opensearch.org'), | ||
| emsTileApiUrl: Joi.string().default('https://tiles.maps.opensearch.org'), | ||
| emsLandingPageUrl: Joi.string().default('https://maps.opensearch.org/v7.10'), |
There was a problem hiding this comment.
Are these dead links? Does it affect the rendering in any way?
There was a problem hiding this comment.
Are these dead links?
Yes but it removes the elastic.co stuff
Does it affect the rendering in any way?
It uses opensearchManifestServiceUrl to actual get the map values. To be honest, there can be additional work that cleans up unneeded stuff.
There was a problem hiding this comment.
I just updated those values to real links. Better to be unused and real rather than used and fake.
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
✅ DCO Check Passed 75a0da2 |
kavilla
added a commit
that referenced
this pull request
May 21, 2021
* [Rename] remove remaining references Some values were added but should not impact current cuts for the public. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Rename] update url for configs Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some values were added but should not impact current cuts of the beta. For example, just maps legacy where the incorrect map config was used. This is not used when running main.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#221
Check List