Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Reduce yarn bootstrap warnings #445

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented Jun 4, 2021

Signed-off-by: Tommy Markley markleyt@amazon.com

Description

There are warnings present in the yarn osd bootstrap process because of the current dependency resolutions. This change resolves all of the warnings that are not related to Typescript. Typescript will need to be addressed in a separate PR which will involve upgrading the version of @elastic/eui to one that utilizes Typescript >=4.0.0.

Before:

$ yarn osd clean
...

$ yarn osd bootstrap
yarn run v1.22.10
$ node scripts/osd bootstrap
 info [opensearch-dashboards] running yarn

$ node ./preinstall_check
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "prismjs@1.22.0" is incompatible with requested version "prismjs@~1.23.0"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "schema-utils@1.0.0" is incompatible with requested version "schema-utils@^0.3.0"
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~3.7.2"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
[3/5] Fetching packages...
info fsevents@1.2.12: The platform "linux" is incompatible with this module.
info "fsevents@1.2.12" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@2.1.2: The platform "linux" is incompatible with this module.
info "fsevents@2.1.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning " > @elastic/eui@29.3.2" has incorrect peer dependency "typescript@^3.7.2".
warning " > @testing-library/react-hooks@3.4.1" has unmet peer dependency "react-test-renderer@>=16.9.0".
warning "workspace-aggregator-e81248c7-dc5b-4ecb-a416-b0ab38ceeb57 > @osd/storybook > @storybook/addon-essentials@6.0.16" has unmet peer dependency "react-is@^16.8.0".
warning "workspace-aggregator-e81248c7-dc5b-4ecb-a416-b0ab38ceeb57 > @osd/storybook > @storybook/addon-essentials > @storybook/addon-docs@6.0.16" has unmet peer dependency "react-is@^16.8.0".
warning "workspace-aggregator-e81248c7-dc5b-4ecb-a416-b0ab38ceeb57 > @osd/storybook > @storybook/addon-essentials > @storybook/addon-docs > @mdx-js/react@1.6.16" has incorrect peer dependency "react@^16.13.1".
[5/5] Building fresh packages...

 succ yarn.lock analysis completed without any issues
 ...
 succ [opensearch-dashboards] bootstrap complete
Done in 126.08s.

After:

$ yarn osd clean
...

$ yarn osd bootstrap
yarn run v1.22.10
$ node scripts/osd bootstrap
 info [opensearch-dashboards] running yarn

$ node ./preinstall_check
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~3.7.2"
[3/5] Fetching packages...
info fsevents@1.2.12: The platform "linux" is incompatible with this module.
info "fsevents@1.2.12" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@2.1.2: The platform "linux" is incompatible with this module.
info "fsevents@2.1.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning " > @elastic/eui@29.3.2" has incorrect peer dependency "typescript@^3.7.2".
warning " > @testing-library/react-hooks@3.4.1" has unmet peer dependency "react-test-renderer@>=16.9.0".
warning "workspace-aggregator-fd4d5602-b5ad-45b2-9db2-08434258621f > @osd/storybook > @storybook/addon-essentials@6.0.16" has unmet peer dependency "react-is@^16.8.0".
warning "workspace-aggregator-fd4d5602-b5ad-45b2-9db2-08434258621f > @osd/storybook > @storybook/addon-essentials > @storybook/addon-docs@6.0.16" has unmet peer dependency "react-is@^16.8.0".
warning "workspace-aggregator-fd4d5602-b5ad-45b2-9db2-08434258621f > @osd/storybook > @storybook/addon-essentials > @storybook/addon-docs > @mdx-js/react@1.6.16" has incorrect peer dependency "react@^16.13.1".
[5/5] Building fresh packages...
success Saved lockfile.

 succ yarn.lock analysis completed without any issues
 ...
 succ [opensearch-dashboards] bootstrap complete
Done in 144.65s.

Issues Resolved

Issues Partially Resolved: #320

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Issues Partially Resolved: opensearch-project#320

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley added the build Build related additions or modifications label Jun 4, 2021
@tmarkley tmarkley added this to the 1.x release milestone Jun 4, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed bce62ec

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmarkley tmarkley merged commit eaa990c into opensearch-project:main Jun 8, 2021
@tmarkley tmarkley deleted the bootstrap-warnings branch June 8, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build related additions or modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: [Discuss][Clean build] Remove warnings
4 participants