[Test] Fix console warning in field_editor.test.tsx #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, unit test field_editor.test.tsx shows a console warning: ```React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. ``` This warning is because EuiCodeEditor is missing in the mock of elastic/eui, which causes undefined EuiCodeEditor in the test. PR Resolved: opensearch-project#673 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
|
✅ DCO Check Passed 027410f |
kavilla
approved these changes
Jul 28, 2021
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 29, 2021
Currently, unit test field_editor.test.tsx shows a console warning: ```React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. ``` This warning is because EuiCodeEditor is missing in the mock of elastic/eui, which causes undefined EuiCodeEditor in the test. PR Resolved: opensearch-project#673 Backport PR: opensearch-project#674 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
5 tasks
ananzh
added a commit
that referenced
this pull request
Jul 29, 2021
Currently, unit test field_editor.test.tsx shows a console warning: ```React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. ``` This warning is because EuiCodeEditor is missing in the mock of elastic/eui, which causes undefined EuiCodeEditor in the test. PR Resolved: #673 Backport PR: #674 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
|
@ananzh I just noticed that you updated snapshots but didn't include the new snapshots in the PR. I'll fix that. |
tmarkley
pushed a commit
to tmarkley/OpenSearch-Dashboards
that referenced
this pull request
Aug 3, 2021
Previous PR opensearch-project#674 did not include updated snapshots. Related to opensearch-project#673 Signed-off-by: Tommy Markley <markleyt@amazon.com>
5 tasks
tmarkley
pushed a commit
that referenced
this pull request
Aug 4, 2021
tmarkley
pushed a commit
to tmarkley/OpenSearch-Dashboards
that referenced
this pull request
Aug 5, 2021
Previous PR opensearch-project#674 did not include updated snapshots. Related to opensearch-project#673 Signed-off-by: Tommy Markley <markleyt@amazon.com>
tmarkley
pushed a commit
that referenced
this pull request
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, unit test field_editor.test.tsx shows a console warning:
This warning is because EuiCodeEditor is missing in the mock of elastic/eui, which causes undefined EuiCodeEditor in the test.
PR Resolved:
#673
Test results
unit test for field_editor.test.tsx
Overall test result:
Check List