Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add data summary panel in discover #8264

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8d52134 from #8186.

* Add data summary panel in discover

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Fix UTs

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Add changelog

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Fix UTs

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

* Address comments

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>

---------

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
(cherry picked from commit 8d52134)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 87.85714% with 17 lines in your changes missing coverage. Please review.

Project coverage is 64.17%. Comparing base (9807a2c) to head (a8df44c).

Files with missing lines Patch % Lines
src/plugins/data/public/search/search_service.ts 15.38% 11 Missing ⚠️
...c/query_assist/components/query_assist_summary.tsx 96.73% 1 Missing and 2 partials ⚠️
...nts/public/query_assist/utils/create_extension.tsx 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8264      +/-   ##
==========================================
+ Coverage   64.14%   64.17%   +0.03%     
==========================================
  Files        3740     3743       +3     
  Lines       88668    88805     +137     
  Branches    13803    13825      +22     
==========================================
+ Hits        56873    56994     +121     
- Misses      31184    31198      +14     
- Partials      611      613       +2     
Flag Coverage Δ
Linux_1 30.04% <0.00%> (-0.01%) ⬇️
Linux_2 58.97% <ø> (ø)
Linux_3 40.37% <15.38%> (-0.01%) ⬇️
Linux_4 31.69% <86.42%> (+0.13%) ⬆️
Windows_1 30.06% <0.00%> (-0.01%) ⬇️
Windows_2 58.92% <ø> (ø)
Windows_3 40.37% <15.38%> (-0.01%) ⬇️
Windows_4 31.69% <86.42%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla merged commit 0515954 into 2.x Sep 23, 2024
68 of 70 checks passed
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…rch-project#8264)

* Add data summary panel in discover



* Fix UTs



* Add changelog



* Fix UTs



* Address comments



* Address comments



* Address comments



---------


(cherry picked from commit 8d52134)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent failed changeset repeat-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants