Used fixed name for dummy ipv6 interface to avoid length issue #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As tracked in openshift-metal3#1124, interface creation can fail if the name exceeds 15 characters. Ensure that for long cluster name the dummy interface that is created will not exceed this lenght by using a fixed name.
bfournie
force-pushed
the
handle-ip-error
branch
from
6904671
to
eecedae
Compare
bfournie
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm I wonder if we should delete the old interface for people who reuse their box. |
The old interface won't get created because of the name length problem, |
I mean, on systems that do not have the length issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tracked in #1124, interface creation can fail if the name exceeds 15 characters. Ensure that for long cluster name the dummy interface that is created will not exceed this length by using a fixed name.