Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Default to kube-proxy health probes for Service type=LoadBalancer #71

Conversation

damdo
Copy link
Member

@damdo damdo commented Jun 7, 2023

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 7, 2023
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member Author

damdo commented Jun 7, 2023

Superseded by #72

@damdo damdo closed this Jun 7, 2023
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-14368. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@damdo damdo changed the title OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer DNM: Default to kube-proxy health probes for Service type=LoadBalancer Jun 7, 2023
@openshift-ci-robot openshift-ci-robot removed jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 7, 2023
@openshift-ci-robot
Copy link

@damdo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-git-history 9cc0a8a link false /test verify-git-history

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants