-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for perspective detection using extensions #5911
Add support for perspective detection using extensions #5911
Conversation
/retest |
1 similar comment
/retest |
frontend/packages/console-plugin-sdk/src/typings/perspectives.ts
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/detect-perspective/DetectPerspective.tsx
Outdated
Show resolved
Hide resolved
a995d4d
to
56de06f
Compare
frontend/packages/console-app/src/components/detect-perspective/PerspectiveDetector.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/detect-perspective/PerspectiveDetector.tsx
Outdated
Show resolved
Hide resolved
a81dcef
to
49450e8
Compare
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
49450e8
to
885f8dd
Compare
/hold cancel Fixed the failing e2e tests. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://issues.redhat.com/browse/ODC-4022
Analysis / Root cause: We want a developer to be directly taken to developer perspective.
Solution Description:
usePerspectiveDetection
which runs the perspective detection.DetectPerspective
component that wraps top levelApp
component and runs perspective detection using the extension mechanism.Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
last-perspective
from local storage.Browser conformance: