-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-4377: introduce microshift ingress performance enhancement #1685
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@eslutsky: This pull request references USHIFT-4377 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2b084b7
to
4b24145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some Qs from the docs side, thank you!
enhancements/microshift/microshift-router-configuration-performance.md
Outdated
Show resolved
Hide resolved
**cluster admin** is a human user responsible for configuring a MicroShift | ||
cluster. | ||
|
||
1. The cluster admin adds specific configuration for the router prior to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an immutable configuration?
Can the user set it day 1 or day 2 after they've started MicroShift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,its router runtime configuration it can be changed on day 2.
## Graduation Criteria | ||
Targeting GA for MicroShift 4.18 release. | ||
|
||
### Dev Preview -> Tech Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we targeting Tech Preview in 4.18, or Dev?
### Removing a deprecated feature | ||
N/A | ||
|
||
## Upgrade / Downgrade Strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these only for minor-version updates/downgrades? What about z-stream updates?
cfccfa8
to
bdf03cc
Compare
45f4583
to
866d4d6
Compare
/test markdownlint |
## Proposal | ||
|
||
Microshift don't use ingress [operator](https://github.com/openshift/cluster-ingress-operator) , all the customization performed through configuration file. | ||
the configuration will propagate to the router deployment [manifest](https://github.com/pacevedom/microshift/blob/8f76e21b9a3f0044c83eae4e2c177871c8235103/assets/components/openshift-router/deployment.yaml) Environment variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the configuration will propagate to the router deployment [manifest](https://github.com/pacevedom/microshift/blob/8f76e21b9a3f0044c83eae4e2c177871c8235103/assets/components/openshift-router/deployment.yaml) Environment variables. | |
the configuration will propagate to the router deployment [manifest](https://github.com/openshift/microshift/blob/aea40ae1ee66dc697996c309268be1939b018f56/assets/components/openshift-router/deployment.yaml) Environment variables. |
enhancements/microshift/microshift-router-configuration-performance.md
Outdated
Show resolved
Hide resolved
866d4d6
to
3f9ac05
Compare
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
3f9ac05
to
b4efa1f
Compare
@eslutsky: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.