Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-4377: introduce microshift ingress performance enhancement #1685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eslutsky
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashcrow for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eslutsky eslutsky changed the title introduce microshift ingress performance enhancement USHIFT-4377: introduce microshift ingress performance enhancement Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024

@eslutsky: This pull request references USHIFT-4377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@eslutsky eslutsky force-pushed the microshift-ingress-performance branch 3 times, most recently from 2b084b7 to 4b24145 Compare September 23, 2024 13:37
Copy link

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some Qs from the docs side, thank you!

**cluster admin** is a human user responsible for configuring a MicroShift
cluster.

1. The cluster admin adds specific configuration for the router prior to

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an immutable configuration?
Can the user set it day 1 or day 2 after they've started MicroShift?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes,its router runtime configuration it can be changed on day 2.

## Graduation Criteria
Targeting GA for MicroShift 4.18 release.

### Dev Preview -> Tech Preview

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we targeting Tech Preview in 4.18, or Dev?

### Removing a deprecated feature
N/A

## Upgrade / Downgrade Strategy

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these only for minor-version updates/downgrades? What about z-stream updates?

@eslutsky eslutsky force-pushed the microshift-ingress-performance branch 16 times, most recently from cfccfa8 to bdf03cc Compare October 8, 2024 09:55
@eslutsky eslutsky marked this pull request as ready for review October 8, 2024 09:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@eslutsky eslutsky force-pushed the microshift-ingress-performance branch 2 times, most recently from 45f4583 to 866d4d6 Compare October 8, 2024 14:06
@eslutsky
Copy link
Contributor Author

eslutsky commented Oct 9, 2024

/test markdownlint

## Proposal

Microshift don't use ingress [operator](https://github.com/openshift/cluster-ingress-operator) , all the customization performed through configuration file.
the configuration will propagate to the router deployment [manifest](https://github.com/pacevedom/microshift/blob/8f76e21b9a3f0044c83eae4e2c177871c8235103/assets/components/openshift-router/deployment.yaml) Environment variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the configuration will propagate to the router deployment [manifest](https://github.com/pacevedom/microshift/blob/8f76e21b9a3f0044c83eae4e2c177871c8235103/assets/components/openshift-router/deployment.yaml) Environment variables.
the configuration will propagate to the router deployment [manifest](https://github.com/openshift/microshift/blob/aea40ae1ee66dc697996c309268be1939b018f56/assets/components/openshift-router/deployment.yaml) Environment variables.

@eslutsky eslutsky force-pushed the microshift-ingress-performance branch from 866d4d6 to 3f9ac05 Compare October 10, 2024 13:16
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@eslutsky eslutsky force-pushed the microshift-ingress-performance branch from 3f9ac05 to b4efa1f Compare October 10, 2024 13:19
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants