Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OVN Observability API enhancement #1693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Oct 7, 2024

OVN Observability is a feature that provides visibility for ovn-kubernetes-managed network by using sampling mechanism.
That means, that network packets generate samples with user-friendly description to give more information about what and why is happening in the network.
In openshift, this feature is integrated with the Network Observability Operator.

The purpose of this enhancement is to define an API to configure OVN observability in an openshift cluster.

cc @dceara @msherif1234 @jotak

@openshift-ci openshift-ci bot requested review from dougbtv and trozet October 7, 2024 13:54
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Contributor

jotak commented Oct 8, 2024

/cc

@openshift-ci openshift-ci bot requested a review from jotak October 8, 2024 06:53
Signed-off-by: Nadia Pinaeva <n.m.pinaeva@gmail.com>
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@npinaeva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint 1c10806 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

- Available by default, but no overhead until observability config CR is created
- Run perf/scale tests and document related metrics to track perf overhead, write down any limitations/recommendations
based on the workload and cluster size
- User facing documentation created in openshift-docs and netobserv docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we may want to support metrics creation via netobserv for the observability events. For example, netobserv can create a metric that reports all network policy traffic denial labelled by namespace / pod etc.
Considering the current tech preview implementation, this would require changing the API interface between netobserv and ovnk-observe.

- old kernel + new OVS: TDB
- old OVS + new OVN: TDB
- old OVN + new ovn-k: rolled out at the same time, no version skew is expected
- old kernel/OVS/ovn-kubernetes + new netobserv: TDB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old kernel/OVS/ovn-kubernetes + new netobserv => netobserv can detect if it's running on older ocp version and warn when the users try to enable the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants